[PATCH] Devicetree support for enc28j60 SPI Ethernet chip

[Mike Frysinger]

On Sun, Oct 14, 2012 at 2:30 PM, Michal Vanka wrote:
> the following patch adds generic openfirmware/devicetree support to enc28j60
> driver.

this should go to the net list, not the mtd list, since this is a net driver

however, your patch needs a little work.  please send it with `git
send-email` rather than formatting things yourself.

> +       if(priv->interrupt_deassert_reg)
> +               writeb(1,priv->interrupt_deassert_reg);

needs a space after the "if" and after the ",".  please run your patch
through checkpatch.pl before re-submitting.

> +static int __devinit enc28j60_of_probe(struct spi_device *spi,struct

more space issues

> +{
> +
> +       u8 *reg;

kill off that blank line

> +       if(prop && len>=sizeof(__be32))

more space issues

> +       if(!devm_request_mem_region(&spi->dev, reg, 4, DRV_NAME))

here too
-mike