[PATCH] [RFC] mtd/uclinux: support ROM and allow passing the base address

Mike Frysinger vapier.adi at gmail.com
Fri Oct 12 00:46:04 EDT 2012


On Tue, Oct 9, 2012 at 6:37 AM, Greg Ungerer <gerg at snapgear.com> wrote:
> On 10/09/2012 06:44 PM, Uwe Kleine-König wrote:
>> On Tue, Oct 09, 2012 at 01:29:46PM +1000, Greg Ungerer wrote:
>>> On 09/10/12 01:25, Uwe Kleine-K÷nig wrote:
>>>> This allows to put the filesystem at a defined address in ROM allowing
>>>> to save more precious RAM.
>>>>
>>>> I think it's save to default to ROM because the intention of using the
>>>> uclinux map is to use a romfs and so mtd-ram doesn't give you anything
>>>> that mtd-rom doesn't.
>>>>
>>>> Signed-off-by: Uwe Kleine-K├Ànig <u.kleine-koenig at pengutronix.de>
>>>
>>> Looks good to me, so:
>>>
>>> Acked-by: Greg Ungerer <gerg at uclinux.org>
>>>
>>> Couple of things to be aware of. Artem currently has a couple of
>>> patches against this file (looks like at least 1 of them is currently
>>> in linux-next). It will probably conflict with your changes, should
>>> be easy enough to fix up.
>>
>> If you tell me a branch to test, I can do so.
>
> Sure. All three patches I sent to the linux-mtd list are here:
>
> The following changes since commit 979570e02981d4a8fc20b3cc8fd651856c98ee9d:
>   Linus Torvalds (1):
>         Linux 3.6-rc7
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git cfmmu
>
> Greg Ungerer (3):
>       mtd: fix wrong usage of ioremap_nocache() in uclinux.c map driver
>       mtd: allow uclinux map driver to be used on any ColdFire CPU platform
>       mtd: clean up uclinux.c map driver
>
>  drivers/mtd/maps/Kconfig   |    2 +-
>  drivers/mtd/maps/uclinux.c |   42
> +++++++++++++++++++-----------------------
>  2 files changed, 20 insertions(+), 24 deletions(-)
>
>
> As far as I can see Artem has pushed the first 2 into for linux-next,
> but not the third. I am hoping he hops in here and lets us know what
> his intentions are with the third...

so to be clear, Uwe's patch hasn't been picked up by anyone yet so we
can get it fixed first ?
-mike



More information about the linux-mtd mailing list