[PATCH] [RFC] mtd/uclinux: support ROM and allow passing the base address

Mike Frysinger vapier.adi at gmail.com
Thu Oct 11 00:21:59 EDT 2012


On Mon, Oct 8, 2012 at 11:25 AM, Uwe Kleine-König wrote:
> --- a/drivers/mtd/maps/uclinux.c
> +++ b/drivers/mtd/maps/uclinux.c
> @@ -23,12 +23,13 @@
>
>  /****************************************************************************/
>
> -struct map_info uclinux_ram_map = {
> -       .name = "RAM",
> -       .phys = (unsigned long)__bss_stop,
> +static struct map_info uclinux_ram_map = {
>         .size = 0,
>  };

this change will break Blackfin systems.  i mentioned last time
someone tried to make this and we talked about adding a comment to
prevent future breakage, but that seems to not have happened.

i don't think's necessary either for the larger change here.  use the logic:
    if (physaddr != -1)
        mapp->phys = physaddr;
and keep the default initialization.
-mike



More information about the linux-mtd mailing list