[PATCH] jffs2: Fix lock acquisition order bug in jffs2_write_begin

Joakim Tjernlund joakim.tjernlund at transmode.se
Mon Oct 8 04:48:04 EDT 2012


>
> Hello Joakim,
>
> I am not sure if it is okay to call jffs2_complete_reservation() without a
> previous jffs2_reserve_space(), so I have avoided that in my own patch.
>
> Also, I am not happy with using ret to check if
> jffs2_complete_reservation() was done; I am using alloc_len for that.
>
> "jffs2_dbg(1, "%s()\n", __func__);" comes a bit late.
>
> And "be be" in the first comment should probably read "be done".

Agreed on all above points, thanks.

>
> I am attaching my own patch for comparison (sorry, I haven't found yet a
> way to send the patch inline); the tests are running this morning.

Right, I don't send inline paches with Notes, I use git send-email

 Jocke




More information about the linux-mtd mailing list