[PATCH v7 3/3] MTD: atmel_nand: Update driver to support Programmable Multibit ECC controller

Artem Bityutskiy dedekind1 at gmail.com
Fri May 18 07:54:23 EDT 2012


On Thu, 2012-05-17 at 13:55 +0100, Russell King - ARM Linux wrote:
> > You can just remove the backslashes. I think your lines splitting is
> > fine otherwise.
> 
> It's also preferred _not_ to wrap error messages as that makes them
> harder to grep for.  Linus has mentioned this several times on LKML
> and has corrected error messages that he encounters that he can't
> find via grep.

OK, thanks for the info.

One could argue that it probably only makes sense to avoid splitting up
to the first %d or another printk placeholder. Beyond the placeholder
grepping is not more difficult.

Well, anyway, I would not like to force people to split or not split
strings. I'd also say that it is more important to follow the style of
the driver/subsystem and be consistent.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120518/3d47ab6c/attachment.sig>


More information about the linux-mtd mailing list