[PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg

Artem Bityutskiy dedekind1 at gmail.com
Tue Mar 13 08:39:28 EDT 2012


On Mon, 2012-03-12 at 10:11 -0700, Joe Perches wrote:
> On Mon, 2012-03-12 at 18:35 +0200, Artem Bityutskiy wrote:
> > On Mon, 2012-03-12 at 08:33 -0700, Joe Perches wrote:
> > > I tentatively converted them to a bitmap
> > > and a single jffs2_dbg(mask, fmt, ...)
> > > but perhaps all of these could be deleted
> > > too.
> > 
> > I think it is better to convert them to jffs2_debug(). And I guess after
> > the change the "mask" parameter will go away?
> 
> Mask would remain and perhaps become a module
> variable instead of a compile #define.
> 
> What is jffs2_debug?

Sorry, I meant to suggest to just turn them all to jffs2_dbg() which you
introduced, without any bitmasks.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120313/960943aa/attachment-0001.sig>


More information about the linux-mtd mailing list