[PATCH 1/2] UBI: allocate verification buffer on demand

Artem Bityutskiy dedekind1 at gmail.com
Fri Mar 9 02:45:09 EST 2012


On Thu, 2012-03-08 at 18:08 +0200, Shmulik Ladkani wrote:
> On Thu,  8 Mar 2012 16:14:50 +0200 Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> > From: Josselin Costanzi <josselin.costanzi at mobile-devices.fr>
> > 
> > Remove the pre-allocated 'peb_buf2' buffer because we do not really need it.
> > The only reason UBI has it is to check that the data were written correctly.
> > But we do not have to have 2 buffers for this and waste RAM - we can just
> > compare CRC checksums instead.
> > 
> > Artem bityutskiy: massaged the patch and commit message
> > 
> > Signed-off-by: Josselin Costanzi <josselin.costanzi at mobile-devices.fr>
> > Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> 
> Josselin's original title "allocate verification buffer on demand" does
> no longer describe this patch.
> Should be "Remove the pre-allocated 'peb_buf2'" or alike.

Fixed as well and pushed out, thanks! Waiting for Josselin's reply
anyway.

commit 43b043e78b876ce27034f167897b57fd2556ad29
Author: Josselin Costanzi <josselin.costanzi at mobile-devices.fr>
Date:   Wed Feb 22 16:37:05 2012 +0100

    UBI: reduce memory consumption
    
    Remove the pre-allocated 'peb_buf2' buffer because we do not really need it.
    The only reason UBI has it is to check that the data were written correctly.
    But we do not have to have 2 buffers for this and waste RAM - we can just
    compare CRC checksums instead. This reduces UBI memory consumption.
    
    Artem bityutskiy: massaged the patch and commit message
    
    Signed-off-by: Josselin Costanzi <josselin.costanzi at mobile-devices.fr>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>


-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list