[PATCH 1/2] UBI: allocate verification buffer on demand

[Josselin Costanzi]

2012/3/9 Josselin Costanzi <josselin.costanzi at mobile-devices.fr>:
> 2012/3/9 Artem Bityutskiy <dedekind1 at gmail.com>:
>> On Thu, 2012-03-08 at 18:08 +0200, Shmulik Ladkani wrote:
>>> On Thu,  8 Mar 2012 16:14:50 +0200 Artem Bityutskiy <dedekind1 at gmail.com> wrote:
>>> > From: Josselin Costanzi <josselin.costanzi at mobile-devices.fr>
>>> >
>>> > Remove the pre-allocated 'peb_buf2' buffer because we do not really need it.
>>> > The only reason UBI has it is to check that the data were written correctly.
>>> > But we do not have to have 2 buffers for this and waste RAM - we can just
>>> > compare CRC checksums instead.
>>> >
>>> > Artem bityutskiy: massaged the patch and commit message
>>> >
>>> > Signed-off-by: Josselin Costanzi <josselin.costanzi at mobile-devices.fr>
>>> > Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
>>>
>>> Josselin's original title "allocate verification buffer on demand" does
>>> no longer describe this patch.
>>> Should be "Remove the pre-allocated 'peb_buf2'" or alike.
>>
>> Fixed as well and pushed out, thanks! Waiting for Josselin's reply
>> anyway.
> I will try to find time to test your patches today and will give my
> feedback ASAP
I'm okay with your version of the patch.
Thanks.

>> commit 43b043e78b876ce27034f167897b57fd2556ad29
>> Author: Josselin Costanzi <josselin.costanzi at mobile-devices.fr>
>> Date:   Wed Feb 22 16:37:05 2012 +0100
>>
>>    UBI: reduce memory consumption
>>
>>    Remove the pre-allocated 'peb_buf2' buffer because we do not really need it.
>>    The only reason UBI has it is to check that the data were written correctly.
>>    But we do not have to have 2 buffers for this and waste RAM - we can just
>>    compare CRC checksums instead. This reduces UBI memory consumption.
>>
>>    Artem bityutskiy: massaged the patch and commit message
>>
>>    Signed-off-by: Josselin Costanzi <josselin.costanzi at mobile-devices.fr>
>>    Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
>>
>>
>> --
>> Best Regards,
>> Artem Bityutskiy
>>
>
>
>
> --
> Josselin Costanzi
>   Embedded Linux System Engineer
>
> Tél. : +33 (0) 1 42 11 93 25
> Fax: +33 (0) 1 42 11 87 17
>
>
> Warning
> This message (and any associated files) is intended only for the use
> of its intended recipient and may contain information that is
> confidential, subject to copyright or constitutes a trade secret. If
> you are not the intended recipient you are hereby notified that any
> dissemination, copying or distribution of this message, or files
> associated with this message, is strictly prohibited. If you have
> received this message in error, please notify us immediately by
> replying to the message and deleting it from your computer. Any views
> or opinions presented are solely those of the author
> josselin.costanzi at mobile-devices.fr and do not necessarily represent
> those of the company. Although the company has taken reasonable
> precautions to ensure no viruses are present in this email, the
> company cannot accept responsibility for any loss or damage arising
> from the use of this email or attachments.



-- 
Josselin Costanzi
  Embedded Linux System Engineer