ubi: suspicious calculation in 'ubi_wl_get_peb'

Shmulik Ladkani shmulik.ladkani at gmail.com
Wed Mar 7 15:08:03 EST 2012


On Wed, 07 Mar 2012 19:20:08 +0200 Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> On Fri, 2012-02-17 at 15:38 +0200, Shmulik Ladkani wrote:
> > -			e = find_wl_entry(&ubi->free, medium_ec);
> > +			e = find_wl_entry(&ubi->free, WL_FREE_MAX_DIFF/2)
> > 
> > Did I get something wrong?
> 
> Yeah, I think you are right. Now I am completely convinced we should
> remove this "short/long-term" stuff because this did even work
> correctly :-)

I would not jump into this conclusion just yet :-)

Note the bug affects UBI_UNKNOWN requests, which are supposed to be
general-purpose 'ubi_wl_get_peb' requests... troubling...

UBI_LONGTERM/UBI_SHORTTERM seem to work just fine.



More information about the linux-mtd mailing list