UBIFS fails to mount on second boot

[Iwo Mergler]

Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> I suspect this is a bug in the free space fixup code - my level of
> confidence on this is 80%. Could you please verify this by removing
> the -F mkfs.ubifs parameter or using the patch below. Thanks!

You're right, the problem doesn't happen without fixup.

I thought I was not flashing empty pages in U-Boot, but that turned
out not to be quite true. Without fixup, the boot died in a hailstorm
of asserts. I fixed that, but now the flashing takes noticeably longer.

In other words, I quite like the fixup feature and would prefer if it doesn't
go away permanently. Otherwise:

Tested-by: Iwo Mergler <Iwo.Mergler at netcommwireless.com>

> 
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index 5862dd9..3398114 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -1295,11 +1295,13 @@ static int mount_ubifs(struct ubifs_info *c)
>  	if (err)
>  		goto out_master;
>  
> +#if 0
>  	if (!c->ro_mount && c->space_fixup) {
>  		err = ubifs_fixup_free_space(c);
>  		if (err)
>  			goto out_lpt;
>  	}
> +#endif
>  
>  	if (!c->ro_mount) {
>  		/*
> 

Best regards,

Iwo

______________________________________________________________________
This communication contains information which may be confidential or privileged. The information is intended solely for the use of the individual or entity named above.  If you are not the intended recipient, be aware that any disclosure, copying, distribution or use of the contents of this information is prohibited.  If you have received this communication in error, please notify me by telephone immediately.
______________________________________________________________________