[PATCH 1/8] mtd: block2mtd: initialize writebufsize

Jörn Engel joern at logfs.org
Sat Feb 4 13:00:35 EST 2012


On Fri, 3 February 2012 10:43:07 +0200, Artem Bityutskiy wrote:
> 
> From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> 
> The writebufsize concept was introduce by commit
> "0e4ca7e mtd: add writebufsize field to mtd_info struct" and it represents
> the maximum amount of data the device writes to the media at a time. This is
> an important parameter for UBIFS which is used during recovery and which
> basically defines how big a corruption caused by a power cut can be.
> 
> However, we forgot to set this parameter for block2mtd. Set it to PAGE_SIZE
> because this is actually the amount of data we write at a time.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> Cc: stable at kernel.org [2.6.38+]
> Cc: Joern Engel <joern at lazybastard.org>

Acked-by: Joern Engel <joern at lazybastard.org>

>From the description of 0e4ca7e it appears as if using a minimum of
say 8 for ubifs recovery would have done the trick as well.  Oh well!

Jörn



More information about the linux-mtd mailing list