[PATCH V5] mtd: m25p80: Make fast read configurable via DT

Kevin Cernekee cernekee at gmail.com
Sat Aug 25 18:06:46 EDT 2012


On Sat, Aug 25, 2012 at 1:40 PM, Marek Vasut <marex at denx.de> wrote:
>> Are there any modern SPI flash parts that can't handle FAST_READ, or
>> is this mostly for compatibility with legacy systems?
>
> We have to support all possibilities, not only "modern systems" .

If the !FAST_READ option only exists to support a tiny number of rare,
ancient flash chips, then it's probably worth pointing that out to the
user in the help text.  Similar to "most users will say 'N' here" in
Kconfig.  Or the help text for CONFIG_MTD_NAND_MUSEUM_IDS.

> Good, but I don't see it supported in the driver, how is this different from
> MX25L256E?

> They can be added as additional DT props, that should be easy.

It's easy to add new features to m25p80, but it's hard to change DT
properties once they are widely used.  They will be baked into
bootloader images and could be utilized by non-Linux operating
systems.

If we already know today that a boolean property is insufficient for
current generations of SPI flash chips, it would not be a good thing
to write it in stone now and be forced to hack around it later.



More information about the linux-mtd mailing list