[PATCH 00/10] nandwrite: cleanup, support ioctl(MEMWRITE)

Artem Bityutskiy dedekind1 at gmail.com
Sun Sep 11 09:06:56 EDT 2011


On Wed, 2011-08-31 at 13:00 -0700, Brian Norris wrote:
> This patch series cleans up old features in nandwrite and supports new
> features with ioctl(MEMWRITE).
> 
> Byproducts of this include:
> (1) kill --raw
> (2) re-implement --autoplace
> (3) support OOB writes for MLC NAND (only write once per page)

I do not have time to thoroughly review the patches, but they look good,
and you make a great job splitting making then easy to follow by
splitting nicely.

I am not very comfortable with "no warning" --raw removal, but we can
try it this way, I guess, it is unlikely someone will be hurt, but there
is some probability.

And last but not least, I think we should not push your changes to the
master branch of mtd-utils _befor_ the corresponding kernel-space
changes have reached Linuses tree (e.g., dwmw2 might dislike something).

So I pushed 2 patches which look independent to the master branch, and
the rest are in the 'brian' branch so far.

Thanks!

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list