[PATCH] mtd: sst25l: fix reads with broken spi-masters

H Hartley Sweeten hartleys at visionengravers.com
Mon Jan 10 17:36:50 EST 2011


On Monday, January 10, 2011 3:20 PM, David Brownell wrote:
> --- On Mon, 1/10/11, H Hartley Sweeten <hartleys at visionengravers.com> wrote:
> NAK.  I'm surprised you even thought to submit
> such a clearly-wrong patch.
>
> The bug is in the SPI master driver, and thus
> so should the fix be.  Or make your system use
> the GPIO based SPI master driver.

Sorry.

The bug _is_ in the spi peripheral on the ep93xx.

Unfortunately, hardware does exist that uses the SFRMOUT signal as part of
the chip select to access the device.  The only way to get this signal to
do anything is by using the spi peripheral.  The SFRMOUT signal cannot be
accessed using GPIO so the GPIO based SPI master driver is not an option.

If the SFRMOUT signal is _not_ used in the chip select logic then everything
works fine.

But... If it's a NAK.. It's a NAK...  I'll try to figure out a way to handle
this in the SPI master driver.

Regards,
Hartley






More information about the linux-mtd mailing list