[PATCH 3/5] mtd: remove MEMSETOOBSEL macro definition

Ricard Wanderlof ricard.wanderlof at axis.com
Wed Aug 24 08:28:31 EDT 2011


On Wed, 24 Aug 2011, Brian Norris wrote:

> MEMSETOOBSEL is completely unused and useless. Remove the definition.
>
> Note: it's probably best not to use this ioctl number in the future for
> MTD, since that may cause conflicts between old kernels and new user
> software (or new kernels and old user software). This shouldn't be much
> problem.

Perhaps this should be noted as a comment in the code, rather than just 
removing the line. Such information tends to get forgotten sooner or later 
otherwise.

>
> Signed-off-by: Brian Norris <computersforpeace at gmail.com>
> ---
> include/mtd/mtd-abi.h |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/mtd/mtd-abi.h b/include/mtd/mtd-abi.h
> index 2f7d45b..f0e8027 100644
> --- a/include/mtd/mtd-abi.h
> +++ b/include/mtd/mtd-abi.h
> @@ -112,7 +112,7 @@ struct otp_info {
> #define MEMUNLOCK		_IOW('M', 6, struct erase_info_user)
> #define MEMGETREGIONCOUNT	_IOR('M', 7, int)
> #define MEMGETREGIONINFO	_IOWR('M', 8, struct region_info_user)
> -#define MEMSETOOBSEL		_IOW('M', 9, struct nand_oobinfo)
> +
> #define MEMGETOOBSEL		_IOR('M', 10, struct nand_oobinfo)
> #define MEMGETBADBLOCK		_IOW('M', 11, __kernel_loff_t)
> #define MEMSETBADBLOCK		_IOW('M', 12, __kernel_loff_t)
> -- 
> 1.7.5.4

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30



More information about the linux-mtd mailing list