[PATCHv3 3/3] serve_image: adjust classifier and type for printf

[Mike Frysinger]

On Tue, Apr 19, 2011 at 10:32, Andy Shevchenko wrote:
> On Tue, 2011-04-19 at 10:26 -0400, ext Mike Frysinger wrote:
>> On Tue, Apr 19, 2011 at 04:34, Andy Shevchenko wrote:
>> > -               fprintf(stderr, "Image size %ld bytes is not a multiple of erasesize %d bytes\n",
>> > -                       st.st_size, erasesize);
>> > +               fprintf(stderr, "Image size %" PRIu64 " bytes is not a multiple of "
>> > +                               "erasesize %d bytes\n", st.st_size, erasesize);
>>
>> i think we want to avoid splitting string constants
>
> I looked to many other places in the code where it has split in string
> constants. So, this is an irrelevant issue.
> However, I could join back the strings which I touch in patches.

the current code base has a lot of ugly code.  but that doesnt mean we
should introduce more, and since you're changing things, it doesnt
make it an irrelevant issue.
-mike