[PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode

Timur Tabi timur.tabi at gmail.com
Tue Sep 14 07:56:44 EDT 2010


On Mon, Sep 13, 2010 at 11:09 PM, Zang Roy-R61911 <r61911 at freescale.com> wrote:

>> > > Shouldn't this be u32 or __be32, for consistency with the actual
>> > > comparisons below?
>> > __be32 is better.
>>
>> I disagree, the return from this function is native-endian.  It should
>> be u32.
> But the return of this value is ONLY used for br comparing. It is big endia.
> Thanks.

No, Scott is right.  The return value is native-endian (NE).  You've
converted it from BE to NE already.

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the linux-mtd mailing list