Do we remove from jedec_probe.c?

Wolfram Sang w.sang at pengutronix.de
Wed May 26 13:53:20 EDT 2010


Hi,

now that Guillaume introduced cfi-support for some SST-flashes, I wonder if
those can be removed from jedec_probe.c? Or should they stay for
backward-compatibility?

Proposed patch would look like this:

diff --git a/drivers/mtd/chips/jedec_probe.c b/drivers/mtd/chips/jedec_probe.c
index d72a5fb..37fdff3 100644
--- a/drivers/mtd/chips/jedec_probe.c
+++ b/drivers/mtd/chips/jedec_probe.c
@@ -146,8 +146,6 @@
 #define SST29LE512	0x003d
 #define SST39LF800	0x2781
 #define SST39LF160	0x2782
-#define SST39VF1601	0x234b
-#define SST39VF3201	0x235b
 #define SST39WF1601	0x274b
 #define SST39WF1602	0x274a
 #define SST39LF512	0x00D4
@@ -1500,19 +1498,6 @@ static const struct amd_flash_info jedec_table[] = {
 			ERASEINFO(0x1000,256)
 		}
 	}, {
-		.mfr_id		= CFI_MFR_SST,     /* should be CFI */
-		.dev_id		= SST39VF1601,
-		.name		= "SST 39VF1601",
-		.devtypes	= CFI_DEVICETYPE_X16,
-		.uaddr		= MTD_UADDR_0xAAAA_0x5555,
-		.dev_size	= SIZE_2MiB,
-		.cmd_set	= P_ID_AMD_STD,
-		.nr_regions	= 2,
-		.regions	= {
-			ERASEINFO(0x1000,256),
-			ERASEINFO(0x1000,256)
-		}
-	}, {
 		/* CFI is broken: reports AMD_STD, but needs custom uaddr */
 		.mfr_id		= CFI_MFR_SST,
 		.dev_id		= SST39WF1601,
@@ -1541,21 +1526,6 @@ static const struct amd_flash_info jedec_table[] = {
 			ERASEINFO(0x1000,256)
 		}
 	}, {
-		.mfr_id		= CFI_MFR_SST,     /* should be CFI */
-		.dev_id		= SST39VF3201,
-		.name		= "SST 39VF3201",
-		.devtypes	= CFI_DEVICETYPE_X16,
-		.uaddr		= MTD_UADDR_0xAAAA_0x5555,
-		.dev_size	= SIZE_4MiB,
-		.cmd_set	= P_ID_AMD_STD,
-		.nr_regions	= 4,
-		.regions	= {
-			ERASEINFO(0x1000,256),
-			ERASEINFO(0x1000,256),
-			ERASEINFO(0x1000,256),
-			ERASEINFO(0x1000,256)
-		}
-	}, {
 		.mfr_id		= CFI_MFR_SST,
 		.dev_id		= SST36VF3203,
 		.name		= "SST 36VF3203",

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20100526/749acccd/attachment.sig>


More information about the linux-mtd mailing list