Faster flash_eraseall for NOR flash

Mike Frysinger vapier.adi at gmail.com
Tue Dec 14 10:38:17 EST 2010


On Tue, Dec 14, 2010 at 10:33, Øyvind Harboe wrote:
>> the only thing it changes in your original patch is to remove the type
>> checking ?
>
> No. There is a different code path for writing the cleanmarkers.

OK, i missed that.  just change the code to issue a warning when
someone tries to use this option on a NAND device.  something like
"--skip-erased: sorry, no support (yet) for NAND devices".

in looking at the original patch, i noticed something else ... dont
mix variable decls and code.  i dont think mtd-utils has moved on to
newer C standards/styles yet and support that.  for example, the
"ssize_t i" decl after a bunch of if statements.
-mike



More information about the linux-mtd mailing list