question about drivers/mtd/ubi/cdev.c

Artem Bityutskiy dedekind1 at gmail.com
Wed Aug 4 02:37:13 EDT 2010


On Wed, 2010-08-04 at 07:48 +0200, Julia Lawall wrote:
> > Hmm, the code is bogus, I do not know how it works, but it does, because
> > I tested it :-)
> >
> > We should not use 're' as a temporary variable inside the loop. I guess
> > we can use 're1' instead. I'll change this later, when have time, unless
> > you submit a fix earlier :-)
> 
> Would the proper approach be to use list_for_each_entry_safe?

Yes, plus not using the iterator as a temporary variable is also a good
idea.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)




More information about the linux-mtd mailing list