[Uclinux-dist-devel] [PATCH v3] mtd/maps: gpio-addr-flash: new driver for GPIO assisted flash addressing

Mike Frysinger vapier.adi at gmail.com
Wed Sep 23 10:54:23 EDT 2009


On Wed, Sep 23, 2009 at 03:16, David Woodhouse wrote:
> On Wed, 2009-09-23 at 00:48 -0400, Mike Frysinger wrote:
>>
>> +       depends on GENERIC_GPIO || GPIOLIB
>
> That still isn't right -- the failing case for me was when GENERIC_GPIO
> was set but _not_ GPIOLIB.
>
> I'll accept an answer of "that's because x86 gpio support is broken",
> but you do have to handle the whining from the 'make randconfig' folks
> for me :)

right, but this code doesnt depend on GPIOLIB.  it needs functioning
GPIO support and GENERIC_GPIO means the arch has a functioning GPIO
core for just the CPU pins.  i'm pretty sure x86 lies in this respect,
so hopefully this randconfig will poke the x86 guys to fix their tree
(or tell me where i'm wrong).  i looked at the x86 Kconfig and it
seems like it should be using "def_bool n" for this symbol, but i'm
not sure that'll fix things.

> And please can you make it an incremental patch against what's in the
> mtd-2.6.git tree (which I've already asked Linus to pull).

sorry, i didnt realize you merged it
-mike



More information about the linux-mtd mailing list