[PATCH] [JFFS2] jffs2_start_garbage_collect_thread() return value cleanup

Andrew Morton akpm at linux-foundation.org
Wed Jun 24 23:00:29 EDT 2009

On Wed, 24 Jun 2009 11:09:01 +0100 David Woodhouse <dwmw2 at infradead.org> wrote:

> On Tue, 2009-06-02 at 15:11 +0300, Gerard Lledo wrote:
> > There is no user of this return value in the kernel.  Change it to return void
> > instead.
> NAK. I hate this type of patch.
> A function _should_ return an error value indicating success or failure,
> if there's _any_ chance that it (or a future rewrite of it) may fail.
> It's up to the _callers_ to act on that result, or not, as they see fit.


> Andrew, may I suggest that you look for such justification in future
> patches of this type?

eh, I sometimes don't even look at them.  I just save them up in case of
maintainer fumblage.

I might retain this one as a "jffs2 fails to check
jffs2_start_garbage_collect_thread() return value" bug report :)

More information about the linux-mtd mailing list