[PATCH] [MTD] phram: cleanup error handling and associated messages
vapier.adi at gmail.com
Wed Jun 17 07:49:43 EDT 2009
On Wed, Jun 17, 2009 at 07:24, Jörn Engel wrote:
> On Wed, 17 June 2009 06:50:18 -0400, Mike Frysinger wrote:
>> The error handling in the phram driver is pretty bad -- in many places,
>> errors are silently ignored or logged, but then still ignored in the
>> return value. So convert all of the code to pass back the correct return
>> value and log error messages properly (and using the new pr_fmt() helper).
> I don't remember why I always returned 0 in phram_setup. Could well
> have been an oversight.
>> If everything does go smoothly, rather than exit silently, dump a helpful
>> info message like pretty much every other MTD driver does.
>> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> Acked-by: Joern Engel <joern at logfs.org>
> Care to take over maintainership? I haven't used this driver in ages
> and don't foresee using it anytime soon.
i actually have no vested interest in this driver either, sorry. i
was asked a question about the driver where the user was using wrong
parameters but they didnt get any feedback -- no kernel messages and
the driver loading did not error out. figured i'd fix it up rather
than have to answer the question again :).
More information about the linux-mtd