[patch 01/14] mtd: Flex-OneNAND support

David Woodhouse dwmw2 at infradead.org
Fri Jun 12 08:52:36 EDT 2009

On Fri, 2009-06-12 at 15:03 +0300, Artem Bityutskiy wrote:
> > flexonenand_setup( ) call is needed only when it has been built as a
> module.
> Why?

Because they're adding a 'flex_bdry_info' module parameter which is a
string, that they then process just the same way as the original command
line option.

I think that's the wrong approach -- please use module_param_array()
instead, so it sets the contents of the flex_bdry[] array directly and
you can remove the flexonenand_setup() function completely.

Please ensure that your email addresses in the Signed-off-by: line are
correct, too. None of this 'user at domain' nonsense.

David Woodhouse                            Open Source Technology Centre
David.Woodhouse at intel.com                              Intel Corporation

More information about the linux-mtd mailing list