[PATCH revised] mtd: remove driver-core BUS_ID_SIZE
anemo at mba.ocn.ne.jp
Mon Jun 8 10:34:11 EDT 2009
On Mon, 08 Jun 2009 09:14:22 +0100, David Woodhouse <dwmw2 at infradead.org> wrote:
> > txx9_priv->cs = -1;
> > - strcpy(txx9_priv->mtdname, dev_name(&dev->dev));
> > + txx9_priv->mtdname = kstrdup(dev_name(&dev->dev),
> > + GFP_KERNEL);
> You don't check for failure here.
> With that fixed, this is your changes as an incremental patch with an
> appropriate commit log... I think it's exceeded the limit of how much
> I'd want to massage your patch while retaining your Signed-off-by:, so
> I'll give you a chance to append your S-o-b for yourself....
> From: Atsushi Nemoto <anemo at mba.ocn.ne.jp>
> Subject: [PATCH] Fix memory leak on probe failure.
> Commit 81933046ef2a615031c46171013bde2c5225ee69 ('mtd: Fix handling of
> mtdname in txx9ndfmc.c') introduced a potential memory leak. The
> 'mtdname' member of the private data structure is now allocated
> separately, but was not freed on certain error paths.
> Fix that, and make things simpler by _always_ allocating it separately
> so that we don't need 'if (mtdname != dev_name()) kfree(mtdname)'...
> which gets ugly now that we're doing it more than once, and more likely
> that we'll get it wrong some time.
Signed-off-by: Atsushi Nemoto <anemo at mba.ocn.ne.jp>
More information about the linux-mtd