[PATCH v3 26/27] [ARM] [NAND] [bcmring] add bcmring umi nand driver support

[Artem Bityutskiy]

Hi,

On Tue, 2009-07-28 at 15:38 -0700, Leo (Hao) Chen wrote:
>  include/linux/mtd/nand_bcm_umi.h              |  241 ++++++++

It does not look like you need to have this header file in
include/linux/mtd/. Also, this file contains huge inline functions,
which is not nice. We are trying not to make functions longer than
1-2 lines inline and let the compiler do the decisions. Of course,
there are exceptions, but your 'nand_bcm_umi_bch_correct_page' does
not look like this. Could you please go through all your inlines and
un-inline non-few-liners?

Sorry, I do not have time to do any real review, but from the stylistic
POW you have too many
/*********************************************************************/
things, as well as ThisLovelyWindowsStyle naming, which we do not
appreciate very much in the Linux Kernel.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)