[resending][PATCH] [MTD] [NAND] nand_ecc.c: Bug fix in nand ecc

Artem Bityutskiy dedekind at infradead.org
Fri Apr 24 03:39:57 EDT 2009


Hi,

On Fri, 2009-04-24 at 12:02 +0530, Singh, Vimal wrote:
> It looks like Frans is not active to this list, now a days...
> so can some one else review this patch:
> http://lists.infradead.org/pipermail/linux-mtd/2009-April/025094.html


It did not apply. Please, send patches which can be applied.

Please, fix you e-mail. Is your address really
"IMCEAEX-_O=TI_OU=BD_CN=RECIPIENTS_CN=X0094262 at dlee86.itg.ti.com" ?

But I fixed both - your patch and your e-mail. Please, check your other
patches and re-send them if they are corrupted. Please, take a look at
Documentation/SubmittingPatches

I've amended your patch a little. Instead of using 'uint32_t', I
made it to be 'int'. I do not see any reason to limit the compiler
and CPU by 32 bits. I do not appreciate unreasonable usage of these
'uint32_t' and similar types, and I think 'int' is perfectly fine
in your case. Could you please verify this? It is here:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git?a=commit;h=e3b8cec094d12aabbfd77c462b1932537e1c239e

Thanks!

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)




More information about the linux-mtd mailing list