[PATCH mtd-utils] fix CFLAGS handling wrt cross compilation

Artem Bityutskiy dedekind at infradead.org
Fri Nov 21 05:41:00 EST 2008


On Wed, 2008-11-19 at 20:52 -0500, Mike Frysinger wrote:
> On Wed, Nov 19, 2008 at 13:31, Nicolas Pitre wrote:
> > Let's have the "new ubi-utils" makefile handle CFLAGS like the other
> > makefiles.  This is important when cross compiling and CFLAGS is
> > externally provided. Without this, local include files are not found due
> > to the various -I arguments which are then lost.
> >
> > Signed-off-by: Nicolas Pitre <nico at marvell.com>
> 
> i dont think sticking CFLAGS into CPPFLAGS is right.  they're separate
> on purpose.  you also break custom CPPFLAG injection here ... CPPFLAGS
> should be treated just like CFLAGS: appended, not strictly set.

May be, I'm bad in Makefile stuff. But this is what the rest of Makefile
files in mtd-utils do, so I've applied Nicolas' patch.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)




More information about the linux-mtd mailing list