[PATCH][JFFS2] Fix garbage collector block search

David Woodhouse dwmw2 at infradead.org
Thu Apr 24 03:28:57 EDT 2008


On Thu, 2008-04-24 at 11:17 +0400, Alexander Belyakov wrote:
> Hm... This script was just the easiest way to reproduce gc bug, but
> not the only. Are you sure this leak won't appear in other sane cases?

I don't believe there's really a leak; certainly not without XATTR.
My own original suspicion was based on a quick glance at debug output
and not seeing blocks getting refiled onto the erase_pending_wbuf list.
But grep shows my initial impression there was wrong.

If the only other evidence of a leak is that jffs2_statfs() reports
fluctuating values, then I'm no more likely to take it seriously than if
you tell me "a pixie told me" :)

Really, we make shit up in jffs2_statfs().

Or do you have other reasons to believe there's a leak? Other than the
one I fixed in commit 014b164e, that is. Although that's only on NOR.

-- 
dwmw2




More information about the linux-mtd mailing list