[PATCH] [JFFS2] Sibley non-contiguous write bug fix

David Woodhouse dwmw2 at infradead.org
Wed Sep 5 06:39:58 EDT 2007


On Wed, 2007-09-05 at 13:35 +0400, Alexander Belyakov wrote:
> Hi David,
> 
> some time ago we have fixed one Sibley non-contiguous write bug:
> http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=3fddb6c985e3823c991399840d2d5ef5940e1b60
> 
> But it seems there is the same bug in another place.
> jffs2_flash_writev() sets 'wbuf_ofs' to the first page in block
> causing a BUG(). Please look at this patch.
> 
> 
> 
> Don't leave the wbuf 'offset' field pointing at the start of the next
> physical eraseblock. This is causing a BUG() on NOR-ECC (Sibley)
> flash.

That looks sane enough, I suppose. But I wonder if instead we should
just be setting c->wbuf_ofs = 0xffffffff in jffs2_find_nextblock()?

-- 
dwmw2




More information about the linux-mtd mailing list