[PATCH] NULLify ->raw after jffs2_mark_node_obsolete().

Joakim Tjernlund joakim.tjernlund at transmode.se
Wed Oct 31 04:32:38 EDT 2007


On Tue, 2007-10-30 at 22:47 -0400, David Woodhouse wrote:
> On Tue, 2007-10-30 at 18:39 +0100, Joakim Tjernlund wrote:
> > Per Davids request, NULLify ->raw pointers to catch
> > errors early.
> 
> Er, did I request that? I wanted you to do that in jffs2_do_unlink(),
> and you did -- but that was because your previous iteration of the patch
> was leaving fd->raw pointing to the _older_, now-obsolete dirent node,
> which could then get marked obsolete again later (at the site of the
> second hunk of your first patch).

Must have misunderstood then, but it makes sense to nullify all such
references, doesn't it? Anyhow I happy with the first part only, the
second patch needs more test.

  Jocke



More information about the linux-mtd mailing list