[RFC] BUG Power loss recovery issues in JFFS2

Alexey Korolev akorolev at infradead.org
Mon Nov 19 09:23:08 EST 2007


Hi David,

> For reasons not entirely clear to me, one of Artem's "debug cleanup"
> patches seems to have completely abandoned the CRC check on data nodes.
> Artem, can you explain commit 733802d974e5af42acb7cd61b16c0ce6dd03b7ed
> for us?
> 
> This seems to make it happy on your two test cases. Note that in your
> 'NEW_FILE' test case, the original node at 0x34000C has already been
> marked obsolete by a buggy kernel, so I needed to mark it valid again:
>  echo -en \\xe0 | dd of=NEW_FILE bs=1 conv=notrunc seek=$((0x34000f)) count=1
> 
> Please test, and then I'll commit it.
> 
> diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c
>
The patch you sent solved the issue for both generic NOR and Sibley.
Commit it please.

Thanks,
Alexey and Roman



More information about the linux-mtd mailing list