PATCH: at91_nand rdy_pin fix

Ivan Kuten ivan.kuten at promwad.com
Thu May 24 04:14:06 EDT 2007


On 24 May 2007 09:47:08 +0200
Andrew Victor wrote:

Should I re-diff or you will apply it corrected?

BR, 
Ivan

> hi Ivan,
> 
> > -       nand_chip->dev_ready = at91_nand_device_ready;
> > +
> > +       if (host->board->rdy_pin)
> > +               nand_chip->dev_ready = at91_nand_device_ready;
> > +       else
> > +               nand_chip->dev_ready = NULL;
> 
> Patch looks correct.
> 
> Since the at91_nand_host structure is allocated with kzalloc(),
> nand_chip->dev_ready is already initialized to NULL.
> So we don't really need the "else" part.
> 
> 
> Regards,
>   Andrew Victor
> 
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/




More information about the linux-mtd mailing list