[PATCH] jffs2, symlink, and 2.6.13

Artem B. Bityutskiy dedekind at infradead.org
Tue Oct 4 09:14:36 EDT 2005


On Tue, 2005-10-04 at 08:02 -0500, Josh Boyer wrote:
> On Tue, 2005-10-04 at 15:16 +0400, Artem B. Bityutskiy wrote:
> > Peter Grayson wrote:
> > > For those on earlier kernel versions, this change will yield compiler
> > > warnings. I am not sure what the policy is for maintaining compatibility
> > > with older kernel versions, so I did not include any changes to
> > > compatmac.h. Do we want to reproduce the struct inode_operations
> > > declaration in compatmac.h just so that latest mtd does not yield
> > > compiler warnings on older kernels?
> > 
> > The patch looks OK. Not sure how to support compatimility, I would just 
> > let gcc print warnings in older kernels. And it looks like it is 
> > harmless. Anyone, comments?
> 
> I'd rather it be added to compatmac.h.  We have things in there that
> support older 2.6 kernels already, so adding another wouldn't hurt.
> There's even a section for kernels older than 2.6.13 already.

Yes, it is better, providing one do it it elegantly and without
introducing any crap to symlink.c.

-- 
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.





More information about the linux-mtd mailing list