[PATCH] OneNAND MTD support

Thomas Gleixner tglx at linutronix.de
Mon Jul 11 04:47:11 EDT 2005


On Mon, 2005-07-11 at 17:30 +0900, Kyungmin Park wrote:
> > Please clean up your includes to avoid redundant includes of header
> > files.
> 
> which one do you mean?
> Are there not required header file?

in omap-onenand.c  

+#include <linux/mtd/mtd.h>
+#include <linux/mtd/onenand.h>
+#include <linux/mtd/partitions.h>

Same in onenand_base.c


in onenand.h you have:

+#include <linux/config.h>
----------^^^^^^^^^^^^^^^^
Not needed, as your header does not contain CONFIG_XXX dependend stuff

+#include <linux/kernel.h>
+#include <linux/spinlock.h>
+#include <linux/mtd/mtd.h>
----------^^^^^^^^^^^^^^^^^
Already included above

+#include <linux/mtd/onenand_regs.h>

tglx






More information about the linux-mtd mailing list