[2.6 patch] MTD: some cleanups

David Woodhouse dwmw2 at redhat.com
Tue Nov 16 13:26:07 EST 2004


On Fri, 2004-11-12 at 14:53 +0100, Adrian Bunk wrote:
> The patch below makes the following cleanups for code under drivers/mtd/ :
> - make some needlessly global code static

OK.

> - remove the following unused code:
>   - function ftl_freepart in drivers/mtd/ftl.c

It's a bug that we never free these. We should call the function
occasionally instead of deleting it.

>   - functions nettel_eraseconfig and nettel_erasecallback,
>    struct nettel_erase in drivers/mtd/maps/nettel.c

The nettel_eraseconfig() function isn't static -- I assume it was called
from the nettel-specific platform code.

>   - function physmap_set_partitions in drivers/mtd/maps/physmap.c

Again that's called from elsewhere.

-- 
dwmw2




More information about the linux-mtd mailing list