[PATCH] MTD Maps driver for Sharp LH7a40x

Thomas Gleixner tglx at linutronix.de
Sun Jun 13 20:07:48 EDT 2004


On Sunday 13 June 2004 23:43, Marc Singer wrote:
> I've removed the ununsed, if-def's and commented, code from the
> driver.
>
> As for the C_MAPS loop, there doesn't seem to be a good way to remove
> it.  Even though there is only one 'chip', we still the map_info
> structure for the simple_map_init() and friends.  The number of code
> code bytes to be saved is nomimal.  The change would be to remove the
> array references.  How do they make the code 'confusing'?

That's not a question of code bytes. 

Why does this code need a for (i = 0; i < C_MAPS;...) loop, if there is only 
one chip which has to be detected, neglected or whatever and C_MAPS is 
therefor 1 ?

In fact the whole driver could be replaced by command line options.

-- 
Thomas





More information about the linux-mtd mailing list