hardcoded maximum number of CFI chips

Jörn Engel joern at wohnheim.fh-wedel.de
Fri Jul 18 09:41:02 EDT 2003


On Fri, 18 July 2003 13:24:14 +0100, Mialkowski, Andrzej wrote:
> 
> Have a problem with limit of 8 CFI chips, my board has currently 10. It
> would be nice to allow specify this in (advanced) configuration. Patch
> proposal below.

My vote is against this patch.  With sufficient chips,
genprobe_ident_chips() will overflow the stack and cause interesting
things to happen.  A better fix would be to look closely at that
function and the other two users of that macro, have them use
kmalloc() and get rid of the whole problem.

Care to have a look?

Jörn

-- 
Simplicity is prerequisite for reliability.
-- Edsger W. Dijkstra



More information about the linux-mtd mailing list