[PATCH RESEND 1/2] regulator: dt-bindings: mt6315: Add regulator supplies

Krzysztof Kozlowski krzk at kernel.org
Wed Mar 25 01:56:00 PDT 2026


On Tue, Mar 24, 2026 at 01:30:28PM +0800, Chen-Yu Tsai wrote:
> diff --git a/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml b/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
> index fa6743bb269d..ba99a0d02bc7 100644
> --- a/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/mt6315-regulator.yaml
> @@ -29,6 +29,16 @@ properties:
>      type: object
>      description: List of regulators and its properties
>  
> +    properties:
> +      pvdd1-supply:
> +        description: Supply for vbuck1
> +      pvdd2-supply:
> +        description: Supply for vbuck2
> +      pvdd3-supply:
> +        description: Supply for vbuck3
> +      pvdd4-supply:
> +        description: Supply for vbuck4

These all look per-regulator supplies, so I think they should be in each
regulator node (see also regulator.yaml).

Or in top-level, but not in "regulators" node. The regulators is only
wrapping node for children.

I wonder what should be our preference - have supplies per regulator or
in top-level node. @Mark, any preference from your side?

> +
>      patternProperties:
>        "^vbuck[1-4]$":
>          type: object
> @@ -51,6 +61,9 @@ examples:
>        reg = <0x6 0>;
>  
>        regulators {
> +        pvdd1-supply = <&pp4200_z2>;
> +        pvdd3-supply = <&pp4200_z2>;

Best regards,
Krzysztof




More information about the Linux-mediatek mailing list