[PATCH v6 0/7] PCI: mediatek-gen3: add power control support

[Chen-Yu Tsai]

On Tue, Mar 24, 2026 at 3:44 PM Manivannan Sadhasivam <mani at kernel.org> wrote:
>
> On Tue, Mar 24, 2026 at 01:19:52PM +0800, Chen-Yu Tsai wrote:
> > Hi folks,
> >
> > This is v6 of my MediaTek PCIe gen3 controller driver power control
> > support series. This series is based on next-20260323, with the
> > commit a2b2ca0c2477 ("Merge branch 'pci/controller/mediatek-gen3'")
> > reverted to drop the older version.
> >
> > This series is ready to be merged. Please drop the older version and use
> > this one instead.
> >
> > Changes since v5:
> > - Link to v5: https://lore.kernel.org/all/20260311075223.3303497-1-wenst@chromium.org/
> > - Adapt to PCI_PWRCTRL_SLOT -> PCI_PWRCTRL_GENERIC Kconfig symbol name change
> >
> > Changes since v4:
> > - Link to v4: https://lore.kernel.org/all/20260310091947.2742004-1-wenst@chromium.org/
> > - Patch 1
> >   - Expanded tabs in commit message
> > - Patch 5
> >   - s/mtk_pcie_device_power_(up|down)/mtk_pcie_devices_power_(up|down)/
> > - Patch 6
> >   - Adapted to mtk_pcie_devices_power_down() name change
> > - Patch 7
> >   - Fixed label typo causing build break
> >   - Replaced "exploded" with "populated" in commit message, and added
> >     more explanation about what "populated onto the mainboard" means.
> >
> > Changes since v3:
> > - Link to v3: https://lore.kernel.org/all/20260302053109.1117091-1-wenst@chromium.org/
> > - Added two patches to move kernel setup code before controller setup
> >   code, and controller setup code before device setup code, as requested
> >   by Bjorn
> > - Dropped dts patches as they are already merged
> >
> > I kept all the existing reviewed-by tags, since the changes to the
> > existing patches aren't that big.
> >
> > Changes since v2:
> > - Link to v2: https://lore.kernel.org/all/20260226092234.3859740-1-wenst@chromium.org/
> > - Made PCIE_MEDIATEK_GEN3 select PCI_PWRCTRL_SLOT, following existing
> >   examples
> >
> > I do wonder why the existing ones don't select PCI_PWRCTRL instead.
> > As there are multiple providers, and now even the M.2 power sequencing
> > driver, I think either we enable the common ones by default, or let
> > the user pick and choose.
> >
>
> I agree with you. I've sent a patch [1] to select these drivers in defconfig to
> make the users life easier. But in the meantime, let's have this dependency
> as-is, otherwise, until my defconfig patch lands, there is no guarantee that
> these drivers will get selected by default.

I would probably just make PCI_PWRCTRL_GENERIC default m or y.

Or make CONFIG_PCI (and probably CONFIG_USB later on) imply
CONFIG_POWER_SEQUENCING_PCIE_M2.

ChenYu


> I'll change these dependencies after v7.1-rc1.
>
> - Mani
>
> [1] https://lore.kernel.org/linux-arm-msm/20260324073931.23739-1-manivannan.sadhasivam@oss.qualcomm.com
>
> > Changes since v1:
> > - Link to v1: https://lore.kernel.org/all/20260224071258.2654521-1-wenst@chromium.org/
> > - commit message for patch 3 was rewritten
> > Jianjun Wang was dropped from the recipients as the email was
> > bouncing.
> >
> > This series adds power control support to the MediaTek PCIe gen3
> > controller driver. This allows proper modeling of WiFi and NVMe
> > adapters in the device tree and control over their power supplies.
> >
> > Patch 1 through 6 are cleanups and minor improvements to the driver.
> >
> > Patch 7 adds power control support using the new pwrctrl API to the
> > PCIe controller driver.
> >
> >
> > Thanks
> > ChenYu
> >
> > [1] https://lore.kernel.org/linux-pci/20260224-pci-m2-e-v5-0-dd9b9501d33c@oss.qualcomm.com/
> >
> > Chen-Yu Tsai (7):
> >   PCI: mediatek-gen3: Clean up mtk_pcie_parse_port() with
> >     dev_err_probe()
> >   PCI: mediatek-gen3: Move mtk_pcie_setup_irq() out of mtk_pcie_setup()
> >   PCI: mediatek-gen3: Move controller setup steps before PERST# control
> >   PCI: mediatek-gen3: Add error path for resume driver callbacks
> >   PCI: mediatek-gen3: Split out device power helpers
> >   PCI: mediatek-gen3: Disable device if further setup fails
> >   PCI: mediatek-gen3: Integrate new pwrctrl API
> >
> >  drivers/pci/controller/Kconfig              |   1 +
> >  drivers/pci/controller/pcie-mediatek-gen3.c | 223 +++++++++++---------
> >  2 files changed, 129 insertions(+), 95 deletions(-)
> >
> > --
> > 2.53.0.983.g0bb29b3bc5-goog
> >
>
> --
> மணிவண்ணன் சதாசிவம்