[PATCH net] net: airoha: add RCU lock around dev_fill_forward_path
Simon Horman
horms at kernel.org
Fri Mar 20 02:19:10 PDT 2026
On Thu, Mar 19, 2026 at 11:26:49AM +0800, Qingfang Deng wrote:
> Since 0417adf367a0 ("ppp: fix race conditions in ppp_fill_forward_path")
> dev_fill_forward_path() should be called with RCU read lock held. This
> fix was applied to net, while the Airoha flowtable commit was applied to
> net-next, so it hadn't been an issue until net was merged into net-next.
>
> Fixes: a9af709fda7e ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
> Signed-off-by: Qingfang Deng <dqfext at gmail.com>
I understand from the patch description that the problem didn't manifest
until this merge commit. But nonetheless I don't think using
a merge commit in the Fixes tag is the best approach. For one thing,
it seems somewhat difficult to use effectively to guide backporting.
I would suggest using the flowtable commit as the fixes tag:
Fixes: a8bdd935d1dd ("net: airoha: Add wlan flowtable TX offload")
Or perhaps fixes tags for both a8bdd935d1dd and 0417adf367a0.
Flagged by AI generated code review, which also suggested citing a8bdd935d1dd.
...
More information about the Linux-mediatek
mailing list