[PATCH] arm64: dts: airoha: en7581: Add switch node to to EN7581 SoC

Lorenzo Bianconi lorenzo at kernel.org
Mon Mar 9 12:48:47 PDT 2026


> > +				gsw_phy1: ethernet-phy at 1 {
> > +					compatible = "ethernet-phy-ieee802.3-c22";
> > +					reg = <9>;
> 
> The @1 should match the reg value. So this is wrong.

ack, I will fix it in v2.

> 
> > +					phy-mode = "internal";
> 
> phy-mode is actually a MAC property, not a PHY property. It is not
> listed in
> Documentation/devicetree/bindings/net/ethernet-phy.yaml. Which also
> suggest this has not been tested using the DT validation tools.

ack, right. I guess this just a leftover of a previous implementation, I will
remove it in v2. Anyway I compiled the dts with the command below:

$make CHECK_DTBS=y W=1 airoha/en7581-evb.dtb

Regards,
Lorenzo

> 
> 	Andrew
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mediatek/attachments/20260309/0166cec1/attachment.sig>


More information about the Linux-mediatek mailing list