[PATCH] soc: mediatek: mtk-dvfsrc: use flex array
kernel test robot
lkp at intel.com
Thu Mar 5 09:57:22 PST 2026
Hi Rosen,
kernel test robot noticed the following build errors:
[auto build test ERROR on kees/for-next/kspp]
[also build test ERROR on linus/master v7.0-rc2 next-20260305]
[cannot apply to kees/for-next/pstore]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/soc-mediatek-mtk-dvfsrc-use-flex-array/20260305-072355
base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/kspp
patch link: https://lore.kernel.org/r/20260304232014.164408-1-rosenp%40gmail.com
patch subject: [PATCH] soc: mediatek: mtk-dvfsrc: use flex array
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20260306/202603060141.sYb2R56a-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260306/202603060141.sYb2R56a-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603060141.sYb2R56a-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/soc/mediatek/mtk-dvfsrc.c:522:59: error: use of undeclared identifier 'num_ops'; did you mean 'num_opps'?
522 | desc = devm_kzalloc(dvfsrc->dev, struct_size(desc, opps, num_ops + 1), GFP_KERNEL);
| ^~~~~~~
| num_opps
include/linux/overflow.h:435:39: note: expanded from macro 'struct_size'
435 | __builtin_choose_expr(__is_constexpr(count), \
| ^
include/linux/compiler.h:326:48: note: expanded from macro '__is_constexpr'
326 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:493:6: note: 'num_opps' declared here
493 | u32 num_opps, gear_info;
| ^
>> drivers/soc/mediatek/mtk-dvfsrc.c:522:59: error: use of undeclared identifier 'num_ops'; did you mean 'num_opps'?
522 | desc = devm_kzalloc(dvfsrc->dev, struct_size(desc, opps, num_ops + 1), GFP_KERNEL);
| ^~~~~~~
| num_opps
include/linux/overflow.h:436:45: note: expanded from macro 'struct_size'
436 | sizeof(*(p)) + flex_array_size(p, member, count), \
| ^
include/linux/overflow.h:419:39: note: expanded from macro 'flex_array_size'
419 | __builtin_choose_expr(__is_constexpr(count), \
| ^
include/linux/compiler.h:326:48: note: expanded from macro '__is_constexpr'
326 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:493:6: note: 'num_opps' declared here
493 | u32 num_opps, gear_info;
| ^
>> drivers/soc/mediatek/mtk-dvfsrc.c:522:59: error: use of undeclared identifier 'num_ops'; did you mean 'num_opps'?
522 | desc = devm_kzalloc(dvfsrc->dev, struct_size(desc, opps, num_ops + 1), GFP_KERNEL);
| ^~~~~~~
| num_opps
include/linux/overflow.h:436:45: note: expanded from macro 'struct_size'
436 | sizeof(*(p)) + flex_array_size(p, member, count), \
| ^
include/linux/overflow.h:420:4: note: expanded from macro 'flex_array_size'
420 | (count) * sizeof(*(p)->member) + __must_be_array((p)->member), \
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:493:6: note: 'num_opps' declared here
493 | u32 num_opps, gear_info;
| ^
>> drivers/soc/mediatek/mtk-dvfsrc.c:522:59: error: use of undeclared identifier 'num_ops'; did you mean 'num_opps'?
522 | desc = devm_kzalloc(dvfsrc->dev, struct_size(desc, opps, num_ops + 1), GFP_KERNEL);
| ^~~~~~~
| num_opps
include/linux/overflow.h:437:53: note: expanded from macro 'struct_size'
437 | size_add(sizeof(*(p)), flex_array_size(p, member, count)))
| ^
include/linux/overflow.h:419:39: note: expanded from macro 'flex_array_size'
419 | __builtin_choose_expr(__is_constexpr(count), \
| ^
include/linux/compiler.h:326:48: note: expanded from macro '__is_constexpr'
326 | (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:493:6: note: 'num_opps' declared here
493 | u32 num_opps, gear_info;
| ^
>> drivers/soc/mediatek/mtk-dvfsrc.c:522:59: error: use of undeclared identifier 'num_ops'; did you mean 'num_opps'?
522 | desc = devm_kzalloc(dvfsrc->dev, struct_size(desc, opps, num_ops + 1), GFP_KERNEL);
| ^~~~~~~
| num_opps
include/linux/overflow.h:437:53: note: expanded from macro 'struct_size'
437 | size_add(sizeof(*(p)), flex_array_size(p, member, count)))
| ^
include/linux/overflow.h:420:4: note: expanded from macro 'flex_array_size'
420 | (count) * sizeof(*(p)->member) + __must_be_array((p)->member), \
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:493:6: note: 'num_opps' declared here
493 | u32 num_opps, gear_info;
| ^
>> drivers/soc/mediatek/mtk-dvfsrc.c:522:59: error: use of undeclared identifier 'num_ops'; did you mean 'num_opps'?
522 | desc = devm_kzalloc(dvfsrc->dev, struct_size(desc, opps, num_ops + 1), GFP_KERNEL);
| ^~~~~~~
| num_opps
include/linux/overflow.h:436:45: note: expanded from macro 'struct_size'
436 | sizeof(*(p)) + flex_array_size(p, member, count), \
| ^
include/linux/overflow.h:421:12: note: expanded from macro 'flex_array_size'
421 | size_mul(count, sizeof(*(p)->member) + __must_be_array((p)->member)))
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:493:6: note: 'num_opps' declared here
493 | u32 num_opps, gear_info;
| ^
>> drivers/soc/mediatek/mtk-dvfsrc.c:522:59: error: use of undeclared identifier 'num_ops'; did you mean 'num_opps'?
522 | desc = devm_kzalloc(dvfsrc->dev, struct_size(desc, opps, num_ops + 1), GFP_KERNEL);
| ^~~~~~~
| num_opps
include/linux/overflow.h:437:53: note: expanded from macro 'struct_size'
437 | size_add(sizeof(*(p)), flex_array_size(p, member, count)))
| ^
include/linux/overflow.h:421:12: note: expanded from macro 'flex_array_size'
421 | size_mul(count, sizeof(*(p)->member) + __must_be_array((p)->member)))
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:493:6: note: 'num_opps' declared here
493 | u32 num_opps, gear_info;
| ^
>> drivers/soc/mediatek/mtk-dvfsrc.c:726:11: error: flexible array requires brace-enclosed initializer
726 | .opps = dvfsrc_opp_mt6893_lp4,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-dvfsrc.c:75:20: note: initialized flexible array member 'opps' is here
75 | struct dvfsrc_opp opps[] __counted_by(num_opp);
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:759:11: error: flexible array requires brace-enclosed initializer
759 | .opps = dvfsrc_opp_mt8183_lp4,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-dvfsrc.c:75:20: note: initialized flexible array member 'opps' is here
75 | struct dvfsrc_opp opps[] __counted_by(num_opp);
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:763:11: error: flexible array requires brace-enclosed initializer
763 | .opps = dvfsrc_opp_mt8183_lp3,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-dvfsrc.c:75:20: note: initialized flexible array member 'opps' is here
75 | struct dvfsrc_opp opps[] __counted_by(num_opp);
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:767:11: error: flexible array requires brace-enclosed initializer
767 | .opps = dvfsrc_opp_mt8183_lp3,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-dvfsrc.c:75:20: note: initialized flexible array member 'opps' is here
75 | struct dvfsrc_opp opps[] __counted_by(num_opp);
| ^
drivers/soc/mediatek/mtk-dvfsrc.c:799:11: error: flexible array requires brace-enclosed initializer
799 | .opps = dvfsrc_opp_mt8195_lp4,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/soc/mediatek/mtk-dvfsrc.c:75:20: note: initialized flexible array member 'opps' is here
75 | struct dvfsrc_opp opps[] __counted_by(num_opp);
| ^
12 errors generated.
vim +522 drivers/soc/mediatek/mtk-dvfsrc.c
489
490 static int dvfsrc_get_hw_opps_v4(struct mtk_dvfsrc *dvfsrc)
491 {
492 struct dvfsrc_opp_desc *desc;
493 u32 num_opps, gear_info;
494 u8 num_vcore, num_dram;
495 u8 num_emi;
496 int i;
497
498 num_opps = dvfsrc_get_opp_count_v4(dvfsrc);
499 if (num_opps == 0) {
500 dev_err(dvfsrc->dev, "No OPPs programmed in DVFSRC MCU.\n");
501 return -EINVAL;
502 }
503
504 /*
505 * The first 16 bits set in the gear info table says how many OPPs
506 * and how many vcore, dram and emi table entries are available.
507 */
508 gear_info = dvfsrc_readl(dvfsrc, DVFSRC_GEAR_INFO_L);
509 if (gear_info == 0) {
510 dev_err(dvfsrc->dev, "No gear info in DVFSRC MCU.\n");
511 return -EINVAL;
512 }
513
514 num_vcore = FIELD_GET(DVFSRC_V4_GEAR_INFO_VCORE, gear_info) + 1;
515 num_dram = FIELD_GET(DVFSRC_V4_GEAR_INFO_DRAM, gear_info) + 1;
516 num_emi = FIELD_GET(DVFSRC_V4_GEAR_INFO_EMI, gear_info) + 1;
517 dev_info(dvfsrc->dev,
518 "Discovered %u gears and %u vcore, %u dram, %u emi table entries.\n",
519 num_opps, num_vcore, num_dram, num_emi);
520
521 /* Allocate everything now as anything else after that cannot fail */
> 522 desc = devm_kzalloc(dvfsrc->dev, struct_size(desc, opps, num_ops + 1), GFP_KERNEL);
523 if (!desc)
524 return -ENOMEM;
525
526 desc->num_opp = num_opps + 1;
527
528 /* Read the OPP table gear indices */
529 for (i = 0; i <= num_opps; i++) {
530 gear_info = dvfsrc_get_opp_gear(dvfsrc, num_opps - i);
531 desc->opps[i].vcore_opp = FIELD_GET(DVFSRC_V4_GEAR_INFO_VCORE, gear_info);
532 desc->opps[i].dram_opp = FIELD_GET(DVFSRC_V4_GEAR_INFO_DRAM, gear_info);
533 desc->opps[i].emi_opp = FIELD_GET(DVFSRC_V4_GEAR_INFO_EMI, gear_info);
534 };
535
536 /* Assign to main structure now that everything is done! */
537 dvfsrc->curr_opps = desc;
538
539 return 0;
540 }
541
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the Linux-mediatek
mailing list