[PATCH v3] ufs: core: add hba parameter to trace events

Peter Wang (王信友) peter.wang at mediatek.com
Tue Jun 30 23:11:37 PDT 2026


On Tue, 2026-06-30 at 17:49 -0400, Steven Rostedt wrote:
> On Tue, 30 Jun 2026 16:56:12 -0400
> Steven Rostedt <rostedt at goodmis.org> wrote:
> 
> > > 
> > >     TP_printk("%s: gating state changed to %s",
> > > -           __get_str(dev_name),
> > > +           dev_name(__entry->hba->dev),
> > 
> > NO YOU CAN NOT DO THIS!!!!
> 
> This is why you should always Cc
> linux-trace-kernel at vger.kernel.org on any
> trace event updates. We look to catch bugs like this.
> 
> The below patch should fix it, and I'll send it as a proper patch
> soon:

Hi Steven,

Thank you for the reminder and for fixing this bug.
This was indeed not thoroughly considered.

However, I am curious: if the HBA is removed, implying that the 
storage would become unusable, might the system encounter an 
I/O hang or shutdown, potentially preventing its detection? 
Perhaps it's a theoretical issue that would not manifest 
in a real-world situation?

Thanks
Peter




More information about the Linux-mediatek mailing list