[PATCH v6 06/17] pinctrl: airoha: an7583: fix muxing of non-gpio default pins

[Krzysztof Kozlowski]

On Sun, Jun 28, 2026 at 05:37:22PM +0300, Mikhail Kshevetskiy wrote:
> Current an7583 pinmux implementation have following issues:
>  * pins 51 and 52 can't be set as pcie_reset, current pcie_reset code
>    will sets pins to gpio mode instead.
>  * there is no proper way to set pins 41--54 to gpio mode.
>  * pins 41--53 can't be actually set as pwm pins. These pins must be
>    muxed to gpio mode as well.
> 
> This patch fixes above issues. Also device tree binding schema
> was updated.

Also was updated? "Also" is a sign you are mixing two commits into one.

Describe WHY you are doing things, not what you did. And describe in
details, becayse "binding was updated" brings no information.

> 
> Fixes: 3ffeb17a9a27 ("pinctrl: airoha: add support for Airoha AN7583 PINs")
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy at iopsys.eu>
> ---
>  .../pinctrl/airoha,an7583-pinctrl.yaml        | 14 ++-
>  drivers/pinctrl/airoha/pinctrl-airoha.c       | 99 ++++++++++++++++---

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof