[PATCH v6 04/17] pinctrl: airoha: an7583: there is no mux to enable the second i2c bus

Krzysztof Kozlowski krzk at kernel.org
Sun Jun 28 23:40:22 PDT 2026


On 29/06/2026 08:38, Krzysztof Kozlowski wrote:
> On Sun, Jun 28, 2026 at 05:37:20PM +0300, Mikhail Kshevetskiy wrote:
>> In the AN7583 case there is no mux bit to enable the second i2c bus,
>> so remove it.
> 
> But you do not remove second i2c bus, but the i2c bus.
> 
>> Also remove i2c pin function from device tree binding schema.
> 
> Why?
> 
>>
>> Fixes: 3ffeb17a9a27 ("pinctrl: airoha: add support for Airoha AN7583 PINs")
>> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy at iopsys.eu>
>> ---
>>  .../bindings/pinctrl/airoha,an7583-pinctrl.yaml        | 10 +---------
>>  drivers/pinctrl/airoha/pinctrl-airoha.c                |  1 -

Also:

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof



More information about the Linux-mediatek mailing list