[PATCH v7 2/3] dt-bindings: net: wireless: mt76: add more PCI devices
Ryder Lee
Ryder.Lee at mediatek.com
Tue Feb 17 05:51:56 PST 2026
On Tue, 2026-02-17 at 14:23 +0100, Krzysztof Kozlowski wrote:
> On 17/02/2026 13:59, Ryder Lee wrote:
> > On Tue, 2026-02-17 at 08:48 +0100, Krzysztof Kozlowski wrote:
> > > On Mon, Feb 16, 2026 at 08:01:15AM -0800, Ryder Lee wrote:
> > > > This adds support for mt7915/mt7916/mt7990/mt7992/mt7996 PCI
> > > > devices.
> > >
> > > No, it does not add any support. I asked you to provide rationale
> > > why
> > > this is needed.
> > >
> > > Also, read submitting patches finally - it is not "This adds...".
> >
> > Are you referring to this - Describe your changes in imperative
> > mood...
>
> Yes
>
> > So, what would you like me to describe this change? what about this
> > "Add platform IDs for known devices"?
>
> First comment - provide rationale why discoverable devices needs to
> be
> described in non-discoverable way...
>
"The rationale for describing these devices is that the WiFi TX power
settings must be provided via the platform's DTS node. Different device
generations interpret these settings differently, so we need to
distinguish them using PCI IDs or compatible strings in the
documentation. The following patch will further explain the differences
in TX power handling between generations."
If you think it's okay, I'll write it this way.
Ryder
More information about the Linux-mediatek
mailing list