[PATCH] pinctrl: mediatek: eint: Drop base from mtk_eint_chip_write_mask()

Linus Walleij linusw at kernel.org
Thu Apr 30 04:15:16 PDT 2026


On Mon, Apr 27, 2026 at 4:11 AM Chen-Yu Tsai <wenst at chromium.org> wrote:

> When support for multiple EINT base addresses was added in commit
> 3ef9f710efcb ("pinctrl: mediatek: Add EINT support for multiple
> addresses"), mtk_eint_chip_write_mask() was changed to write interrupt
> masks for all base addresses in one call. However the "base" parameter
> was left around and now causes sparse warnings:
>
>     mtk-eint.c:428:44: warning: incorrect type in argument 2 (different address spaces)
>     mtk-eint.c:428:44:    expected void [noderef] __iomem *base
>     mtk-eint.c:428:44:    got void [noderef] __iomem **base
>     mtk-eint.c:436:44: warning: incorrect type in argument 2 (different address spaces)
>     mtk-eint.c:436:44:    expected void [noderef] __iomem *base
>     mtk-eint.c:436:44:    got void [noderef] __iomem **base
>
> Since the "base" parameter is no longer needed, just drop it.
>
> Fixes: 3ef9f710efcb ("pinctrl: mediatek: Add EINT support for multiple addresses")
> Cc: Hao Chang <ot_chhao.chang at mediatek.com>
> Cc: Qingliang Li <qingliang.li at mediatek.com>
> Signed-off-by: Chen-Yu Tsai <wenst at chromium.org>

Patch applied because looks correct!

Yours,
Linus Walleij



More information about the Linux-mediatek mailing list