[PATCH net] net: airoha: Do not read uninitialized fragment address in airoha_dev_xmit()
Jakub Kicinski
kuba at kernel.org
Mon Apr 27 17:39:35 PDT 2026
On Sat, 25 Apr 2026 16:10:51 +0200 Lorenzo Bianconi wrote:
> - Does the TSO checksum calculation earlier in this function ensure the
> TCP header is in the linear portion of the SKB?
> This issue is not related to the current patch. Moreover, can we have a TSO
> packet where the tcp header is not in the linear area of the skb?
Don't think so.
> - If dma_map_single() fails partway through a multi-fragment packet and
> triggers this goto error_unmap, will it break the Tx ring contiguity?
> This issue is not related to the current patch. Moreover, I guess the hw is
> capable of managing out-of-order descriptors.
>
> - Is it safe to map fragment data using dma_map_single() instead of
> skb_frag_dma_map()?
> This issue is not related to the current patch. I will post a dedicated patch
> for it.
I don't think it's an issue. Unless you support DMABUF zero-copy
the skb_frag helper is just for convenience. I wouldn't bother.
More information about the Linux-mediatek
mailing list