[PATCH v19 4/4] media: platform: mtk-mdp3: add Mediatek MDP3 driver

[moudy.ho]

On Mon, 2022-06-27 at 11:51 +0800, CK Hu wrote:
> Hi, Moudy:
> 
> On Fri, 2022-06-24 at 17:23 +0800, Moudy Ho wrote:
> > This patch adds driver for Mediatek's Media Data Path ver.3 (MDP3).
> > It provides the following functions:
> >   color transform, format conversion, resize, crop, rotate, flip
> >   and additional image quality enhancement.
> > 
> > The MDP3 driver is mainly used for Google Chromebook products to
> > import the new architecture to set the HW settings as shown below:
> >   User -> V4L2 framework
> >     -> MDP3 driver -> SCP (setting calculations)
> >       -> MDP3 driver -> CMDQ (GCE driver) -> HW
> > 
> > Each modules' related operation control is sited in mtk-mdp3-comp.c
> > Each modules' register table is defined in file with "mdp_reg_"
> > prefix
> > GCE related API, operation control  sited in mtk-mdp3-cmdq.c
> > V4L2 m2m device functions are implemented in mtk-mdp3-m2m.c
> > Probe, power, suspend/resume, system level functions are defined in
> > mtk-mdp3-core.c
> > 
> 
> [snip]
> 
> > 
> > +
> > +int mdp_cmdq_send(struct mdp_dev *mdp, struct mdp_cmdq_param
> > *param)
> > +{
> > +	struct mdp_path *path = NULL;
> > +	struct mdp_cmdq_cmd *cmd = NULL;
> > +	struct mdp_comp *comps = NULL;
> > +	struct device *dev = &mdp->pdev->dev;
> > +	int i, ret;
> > +
> > +	atomic_inc(&mdp->job_count);
> > +	if (atomic_read(&mdp->suspended)) {
> > +		atomic_dec(&mdp->job_count);
> > +		return -ECANCELED;
> > +	}
> > +
> > +	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
> > +	if (!cmd) {
> > +		ret = -ENOMEM;
> > +		goto err_cmdq_data;
> > +	}
> > +
> > +	if (mdp_cmdq_pkt_create(mdp->cmdq_clt, &cmd->pkt, SZ_16K)) {
> > +		ret = -ENOMEM;
> > +		goto err_cmdq_data;
> > +	}
> > +
> > +	comps = kcalloc(param->config->num_components, sizeof(*comps),
> > +			GFP_KERNEL);
> > +	if (!comps) {
> > +		ret = -ENOMEM;
> > +		goto err_cmdq_data;
> > +	}
> > +
> > +	path = kzalloc(sizeof(*path), GFP_KERNEL);
> > +	if (!path) {
> > +		ret = -ENOMEM;
> > +		goto err_cmdq_data;
> > +	}
> > +
> > +	path->mdp_dev = mdp;
> > +	path->config = param->config;
> > +	path->param = param->param;
> > +	for (i = 0; i < param->param->num_outputs; i++) {
> > +		path->bounds[i].left = 0;
> > +		path->bounds[i].top = 0;
> > +		path->bounds[i].width =
> > +			param->param->outputs[i].buffer.format.width;
> > +		path->bounds[i].height =
> > +			param->param->outputs[i].buffer.format.height;
> > +		path->composes[i] = param->composes[i] ?
> > +			param->composes[i] : &path->bounds[i];
> > +	}
> > +
> > +	ret = mdp_path_ctx_init(mdp, path);
> > +	if (ret) {
> > +		dev_err(dev, "mdp_path_ctx_init error\n");
> > +		goto err_cmdq_data;
> > +	}
> > +
> > +	cmd->event = &mdp->event[0];
> > +	ret = mdp_path_config(mdp, cmd, path);
> > +	if (ret) {
> > +		dev_err(dev, "mdp_path_config error\n");
> > +		goto err_cmdq_data;
> > +	}
> > +	cmdq_pkt_finalize(&cmd->pkt);
> > +
> > +	for (i = 0; i < param->config->num_components; i++)
> > +		memcpy(&comps[i], path->comps[i].comp,
> > +		       sizeof(struct mdp_comp));
> > +
> > +	mdp->cmdq_clt->client.rx_callback = mdp_handle_cmdq_callback;
> > +	cmd->mdp = mdp;
> > +	cmd->user_cmdq_cb = param->cmdq_cb;
> > +	cmd->user_cb_data = param->cb_data;
> > +	cmd->comps = comps;
> > +	cmd->num_comps = param->config->num_components;
> > +	cmd->mdp_ctx = param->mdp_ctx;
> > +
> > +	mtk_mutex_prepare(mdp->mdp_mutex[MDP_PIPE_RDMA0]);
> > +	ret = mdp_comp_clocks_on(&mdp->pdev->dev, cmd->comps, cmd-
> > > num_comps);
> > 
> > +	if (ret) {
> > +		dev_err(dev, "comp %d failed to enable clock!\n", ret);
> > +		goto err_clock_off;
> > +	}
> > +
> > +	dma_sync_single_for_device(mdp->cmdq_clt->chan->mbox->dev,
> > +				   cmd->pkt.pa_base, cmd-
> > > pkt.cmd_buf_size,
> > 
> > +				   DMA_TO_DEVICE);
> > +	ret = mbox_send_message(mdp->cmdq_clt->chan, &cmd->pkt);
> > +	if (ret < 0) {
> > +		dev_err(dev, "mbox send message fail %d!\n", ret);
> > +		goto err_clock_off;
> > +	}
> > +	mbox_client_txdone(mdp->cmdq_clt->chan, 0);
> > +
> > +	kfree(path);
> > +	return 0;
> > +
> > +err_clock_off:
> > +	mtk_mutex_unprepare(mdp->mdp_mutex[MDP_PIPE_RDMA0]);
> > +	mdp_comp_clocks_off(&mdp->pdev->dev, cmd->comps,
> > +			    cmd->num_comps);
> > +err_cmdq_data:
> > +	kfree(path);
> > +	atomic_dec(&mdp->job_count);
> > +	wake_up(&mdp->callback_wq);
> > +	if (cmd->pkt.buf_size > 0)
> > +		mdp_cmdq_pkt_destroy(&cmd->pkt);
> > +	kfree(comps);
> > +	kfree(cmd);
> > +	return ret;
> > +}
> 
> EXPORT_SYMBOL(mdp_cmdq_send);
> 
> So other kernel module could call this function.
> 
> Regards,
> CK
> 

Hi CK,

Thanks for the suggestion, it will be modified in the next version.

Regards,
Moudy